Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM for HLT VBF Hbb #7387

Merged
merged 7 commits into from Jan 30, 2015
Merged

DQM for HLT VBF Hbb #7387

merged 7 commits into from Jan 30, 2015

Conversation

silviodonato
Copy link
Contributor

This PR updates the DQM for HLT VBF Hbb paths, according to https://its.cern.ch/jira/browse/CMSHLT-234 .
Here the VBFHbb folder is splitted in:

  • VBFHbb_0btag
  • VBFHbb_1btag
  • VBFHbb_2btag
    in order to:
  • have more statistic for trigger that doesn't use b-tagging
  • remove useless plots (eg. turn-on vs CSV1 for a trigger path with no b-tag).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_4_X.

DQM for HLT VBF Hbb

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@silviodonato
Copy link
Contributor Author

Example of output (for VBF paths):
/afs/cern.ch/user/s/sdonato/AFSwork/public/DQM_VBF_Hbb.root

@ghost
Copy link

ghost commented Jan 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 17c601c
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 27-Jan-2015 13:44:48 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module HBHEIsolatedNoiseReflagger/'hbhereco'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: trackExtrapolator
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 27-Jan-2015 13:45:11 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module HBHEIsolatedNoiseReflagger/'hbhereco'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: trackExtrapolator
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7387/2143/summary.html

@silviodonato
Copy link
Contributor Author

Is it my fault? Or an error of the IB?

@davidlange6
Copy link
Contributor

please test
(its an error of the IB)

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 30, 2015
@cmsbuild cmsbuild merged commit e6cb0fc into cms-sw:CMSSW_7_4_X Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants