Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the track associator in HI Track Validation #7404

Merged
merged 3 commits into from Jan 30, 2015
Merged

Change the track associator in HI Track Validation #7404

merged 3 commits into from Jan 30, 2015

Conversation

kkrajczar
Copy link
Contributor

This PR is a workaround to the "RuntimeError: An entry in sequence tracksValidationFS has no label" error observed in recent IBs for HI Validation. That problem seems to be caused by PR #7175 (main authors are @Dr15Jones and @davidlange6). Please see other comments in that PR, PR #7175 .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_4_X.

Change the track associator in HI Track Validation

It involves the following packages:

Validation/RecoHI

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@RylanC24, @richard-cms this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

-1 - do not change parameters of existing modules - the clone is needed

@cmsbuild
Copy link
Contributor

Pull request #7404 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@kkrajczar
Copy link
Contributor Author

Hi David,

It turned out that the parameter already had the value it was changed to ('reco'), so I removed the superfluous parameter change. Now, the existing module is used as is.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #7404 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1
Tested at: a7e7f39
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 28-Jan-2015 19:18:51 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7404/2182/summary.html

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 30, 2015
Change the track associator in HI Track Validation
@cmsbuild cmsbuild merged commit ab47dfc into cms-sw:CMSSW_7_4_X Jan 30, 2015
@kkrajczar kkrajczar deleted the HITrackingValidationWorkaround branch February 11, 2015 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants