Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecalmultifit hlt from731patch1 #7429

Merged

Conversation

emanueledimarco
Copy link
Contributor

@argiro @bendavid @matteosan1 @fwyzard @gennai

This includes fast version of multifit ECAL local reconstruction meant for HLT.
Default parameters are for offline reconstruction (full multifit).

The default behavior is the same as before, so no change is expected. The fast version of the local reconstruction will be triggered by changing the parameters doPrefitEB and doPrefitEE via the HLT menu.

These changes will be ported to 7.4.X branch also.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_3_X.

Ecalmultifit hlt from731patch1

It involves the following packages:

RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost
Copy link

ghost commented Jan 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2015

+1

for #7429 edcc57c
the relevant code changes are the same as in #7441
jenkins tests show that
there are no changes in the tested workflows, as expected (the feature is disabled by default).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants