Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate all products needed by Sim/Reco-level mixing (in 7_4_X) #7438

Merged
merged 1 commit into from Jan 29, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 28, 2015

Mixing in pileup at the Sim/Reco level, as done in fast simulation, does not work, because, while three different product types are mixed, only one of these product types is kept on input. This simple pull request adds one line of code to keep each of the other two needed product types. Note: This mixing currently works accidentally if only one pileup file is specified, because the first pileup file is opened at construction time, before the list of product types to be dropped is activated. So, Sim/Reco level mixing fails only if more than one pileup file is specified. This pull request fixes the failure.
This problem was reported by Jason Gran.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Activate all products needed by Sim/Reco-level mixing (in 7_4_X)

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jan 29, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 29, 2015
Activate all products needed by Sim/Reco-level mixing (in 7_4_X)
@cmsbuild cmsbuild merged commit 8c41deb into cms-sw:CMSSW_7_4_X Jan 29, 2015
@wmtan wmtan deleted the FixSimRecoMixingIn7_4_X branch February 3, 2015 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants