New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate all products needed by Sim/Reco-level mixing (in 7_4_X) #7438
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Activate all products needed by Sim/Reco-level mixing (in 7_4_X) It involves the following packages: SimGeneral/MixingModule @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Activate all products needed by Sim/Reco-level mixing (in 7_4_X)
Mixing in pileup at the Sim/Reco level, as done in fast simulation, does not work, because, while three different product types are mixed, only one of these product types is kept on input. This simple pull request adds one line of code to keep each of the other two needed product types. Note: This mixing currently works accidentally if only one pileup file is specified, because the first pileup file is opened at construction time, before the list of product types to be dropped is activated. So, Sim/Reco level mixing fails only if more than one pileup file is specified. This pull request fixes the failure.
This problem was reported by Jason Gran.