Lhe interface update for pythia 8.205 (74x) #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is no longer needed in pythia 8.205 when multiplicities are steered automatically
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
|
-1 >> Package FWCore/Version built
>> Subsystem FWCore built
>> Building edm plugin tmp/slc6_amd64_gcc491/src/GeneratorInterface/Pythia8Interface/test/ZJetsTestAnalyzer/libZJetsTestAnalyzer.so
>> Building shared library tmp/slc6_amd64_gcc491/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-28-1400/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc: In member function 'bool Pythia8Hadronizer::initializeForExternalPartons()':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-28-1400/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:442:37: error: invalid new-expression of abstract class type 'LHAupLesHouches'
lhaUP.reset(new LHAupLesHouches());
^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-28-1400/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:43:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-28-1400/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.h:22:7: note: because the following virtual functions are pure within 'LHAupLesHouches':
class LHAupLesHouches : public Pythia8::LHAup {
you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). |
davidlange6
added a commit
that referenced
this pull request
Jan 29, 2015
Lhe interface update for pythia 8.205 (74x)
|
failures expected without cmsdist changes. I have merged both |
|
This breaks jenkins tests! Please fix or revert! |
bendavid
pushed a commit
to bendavid/cmssw
that referenced
this pull request
Jan 30, 2015
Lhe interface update for pythia 8.205 (74x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be taken together with pythia update in cmsdist
cms-sw/cmsdist#1340