Retrieve collections from LazyTools

[shervin86]

EcalClusterLazyTools are widely used in many analysis.
Once the object is built, it has as private members the handles to many collections.
With this modification, it is also possible to retrieve the collections from the object, instead of declaring handles separately.

[cmsbuild]

A new Pull Request was created by @shervin86 for CMSSW_7_4_X.

Retrieve collections from LazyTools

It involves the following packages:

RecoEcal/EgammaCoreTools

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[ghost]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 161a601
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7449/2222/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7449/2222/summary.html

[slava77]

these are more obviously prompting to suggest that the methods should be const-qualified.
Looking at other methods, there are actually quite a few more methods that should be made const-qualified as well.
This is something to put on the list of possible code cleanup one day.

[slava77]

+1

for #7449 161a601

new methods added are ~trivial, compiles ok by jenkins

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.