Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoHI/HiJetAlgos: resolve GCC warnings about unknown pragma #7450

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 29, 2015

GCC correctly ignores unknown (Clang) pragma. These warnings needs to be
disabled in command line and not via #pragma GCC diagnostic, which does
not correctly work with GCC (a long standing bug in C++ preprocessor).

Marking #pragma as GCC will not help as warning is Clang specific, not
yet supported in GCC.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

GCC correctly ignores unknown Clang pragma. These warnings needs to be
disabled in command line and not via #pragma GCC diagnostic, which does
not correctly with GCC (a long standing bug in C++ preprocessor).

Marking #pragma as GCC will not help as warning is Clang specific, not
yet supported in GCC.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_4_X.

RecoHI/HiJetAlgos: resolve GCC warnings about unknown pragma

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2015

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 30, 2015
…-GCC

RecoHI/HiJetAlgos: resolve GCC warnings about unknown pragma
@cmsbuild cmsbuild merged commit ec14a02 into cms-sw:CMSSW_7_4_X Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants