Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed construction of RefProd from RefVector #7486

Merged

Conversation

Dr15Jones
Copy link
Contributor

Changes in the framework will remove the ability to create a RefProd
from a RefVector.

Changes in the framework will remove the ability to create a RefProd
from a RefVector.
@Dr15Jones
Copy link
Contributor Author

@wddgit

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Removed construction of RefProd from RefVector

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

@vadler @monttj ping

@monttj
Copy link
Contributor

monttj commented Feb 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 2, 2015
Removed construction of RefProd from RefVector
@cmsbuild cmsbuild merged commit 401bc85 into cms-sw:CMSSW_7_4_X Feb 2, 2015
@Dr15Jones Dr15Jones deleted the noRefProdFromRefVectorInPatAlgos branch February 25, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants