Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4e integration in 7_4_X #7505

Merged
merged 11 commits into from Feb 4, 2015
Merged

Conversation

lviliani
Copy link
Contributor

@lviliani lviliani commented Feb 2, 2015

Added TrackPropagation/Geant4e package.
Some changes to RecoTracker/TrackProducer, TrackingTools/PatternTools to enable the propagation to PCA using a non analytical propagator.
Changes to SimG4Core/GeometryProducer in order to allow the propagation with Geant4e.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

A new Pull Request was created by @lviliani (Lorenzo Viliani) for CMSSW_7_4_X.

Geant4e integration in 7_4_X

It involves the following packages:

RecoTracker/TrackProducer
SimG4Core/GeometryProducer
TrackPropagation/Geant4e
TrackingTools/PatternTools

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @bellan, @gpetruc, @cerati, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Feb 2, 2015

@lviliani, in SimG4Core/GeometryProducer/interface/GeometryProducer.h you really need sensitive detectors in some cases?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2015

+1

for #7505 69a4cc8
tested in CMSSW_7_4_X_2015-02-02-0200 /test area sign510/
after the latest fix the differences went away.
the timing is the same now too.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants