Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaced Global Muon Reconstruction #7531

Merged
merged 9 commits into from Feb 5, 2015
Merged

Displaced Global Muon Reconstruction #7531

merged 9 commits into from Feb 5, 2015

Conversation

prbbing
Copy link
Contributor

@prbbing prbbing commented Feb 3, 2015

Here it is the first implementation of the Global Displaced Muon Reconstruction.

It introduced displaced racking sequences and all the changes are located in the RecoMuon package.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

A new Pull Request was created by @prbbing (bingxuan liu) for CMSSW_7_4_X.

Displaced Global Muon Reconstruction

It involves the following packages:

RecoMuon/Configuration
RecoMuon/MuonIdentification
RecoTracker/FinalTrackSelectors

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @bellan, @gpetruc, @cerati, @rociovilar, @trocino, @dgulhan, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

-1
Tested at: 5cc3367
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 03-Feb-2015 23:08:47 CET-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module MuonIdProducer/'earlyDisplacedMuons'
Exception Message:
Failed to get input track collection with label: InputTag:  label = earlyGeneralTracks, instance = 
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7531/2331/summary.html

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 5, 2015

+1

For #7531 5a602b8

Adding displaced muon reconstruction sequences.

Code changes are satisfactory.

Jenkins tests CMSSW_7_4_X_2015-02-04-0200 show only minor differences related to other PRs, because Jenkins did not use the original IB (CMSSW_7_4_0_pre6) this PR was derived from.

Extended tests with workflows 1313.0 and 25202.0 show no significant differences from baseline. The new sequences add about 140 ms / event processing time and about 2600 bytes to the size of each event (which is less than 1% of the total size) for both RECO and AODSIM. These changes were expected from the report of the developers to the Jan. 29, 2015, Reco meeting.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants