New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaced Global Muon Reconstruction #7531
Conversation
A new Pull Request was created by @prbbing (bingxuan liu) for CMSSW_7_4_X. Displaced Global Muon Reconstruction It involves the following packages: RecoMuon/Configuration @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log ----- Begin Fatal Exception 03-Feb-2015 23:08:47 CET----------------------- An exception of category 'FatalError' occurred while [0] Processing run: 182124 lumi: 40 event: 1893722 [1] Running path 'reconstruction_step' [2] Calling event method for module MuonIdProducer/'earlyDisplacedMuons' Exception Message: Failed to get input track collection with label: InputTag: label = earlyGeneralTracks, instance = ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
+1 Adding displaced muon reconstruction sequences. Code changes are satisfactory. Jenkins tests CMSSW_7_4_X_2015-02-04-0200 show only minor differences related to other PRs, because Jenkins did not use the original IB (CMSSW_7_4_0_pre6) this PR was derived from. Extended tests with workflows 1313.0 and 25202.0 show no significant differences from baseline. The new sequences add about 140 ms / event processing time and about 2600 bytes to the size of each event (which is less than 1% of the total size) for both RECO and AODSIM. These changes were expected from the report of the developers to the Jan. 29, 2015, Reco meeting. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Displaced Global Muon Reconstruction
Here it is the first implementation of the Global Displaced Muon Reconstruction.
It introduced displaced racking sequences and all the changes are located in the RecoMuon package.