Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preprocessor check on boost version #7553

Merged
merged 1 commit into from Feb 4, 2015
Merged

add preprocessor check on boost version #7553

merged 1 commit into from Feb 4, 2015

Conversation

davidlange6
Copy link
Contributor

Hack to support boost 1.51 and 1.57 while we have to revert back to 1.51 (rebased)

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Feb 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

add preprocessor check on boost version

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor Author

@cmsbuild, please test

On Feb 4, 2015, at 12:14 PM, cmsbuild notifications@github.com
wrote:

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

add preprocessor check on boost version

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

—
Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

The tests are being triggered in jenkins.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

davidlange6 added a commit that referenced this pull request Feb 4, 2015
@davidlange6
Merge pull request #7553 from davidlange6/hack_boost_version2
77d3ff5 
add preprocessor check on boost version
@davidlange6 davidlange6 merged commit 77d3ff5 into cms-sw:CMSSW_7_4_X Feb 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

+1
Tested at: 9d0402d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7553/2360/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7553/2360/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-started
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlange6 @cmsbuild @fwyzard