Adding Pythia8 capability to TopDecaySubset #7577
Conversation
|
A new Pull Request was created by @kreczko (Luke Kreczko) for CMSSW_7_4_X. Adding Pythia8 capability to TopDecaySubset It involves the following packages: TopQuarkAnalysis/Configuration @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
| @@ -43,12 +47,34 @@ class TopDecaySubset : public edm::EDProducer { | |||
| private: | |||
| /// find top quarks in list of input particles | |||
| std::vector<const reco::GenParticle*> findTops(const reco::GenParticleCollection& parts); | |||
| /// find primal top quarks (top quarks from the hard interaction) | |||
| /// for Pythia6 this is identical to findDecayingTops | |||
| std::vector<const reco::GenParticle*> findPrimalTops(const reco::GenParticleCollection& parts); | |||
There was a problem hiding this comment.
@kreczko
Hello,
If this findPrimalTops is identical to findTops for pythia6, we could simply replace the implementation of findTops with new one. In this way, it can be transparent for any analyzers who are using this function for both Run 1 and Run 2?
Maybe I missed something here.
Regards,
Taejeong
There was a problem hiding this comment.
@monttj
Hi,
While the functionality is identical I was told by the TOP PAG conveners not to change run1 code but instead build in switches to enable the new code on demand. I am all in favour in reducing code on the one hand, but on the other I would not replace the code without a unit test verifying its functionality.
Maybe I can add such tests and talk to the conveners. Do you know of any good unit test examples where GenParticleCollections are used? I am not sure how I would construct a mock genparticle collection.
Cheers,
Luke
There was a problem hiding this comment.
Hi Luke,
I am not sure about the unit test for this package.
But you already communicated with TOP PAG conveners and agreed each other,
and this does not affect old functionality,
so I don't see any problem to have this necessary new features for Run 2.
Thank you for the development.
Regards,
Taejeong
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
|
+1 |
Adding Pythia8 capability to TopDecaySubset
This pull request is for the TopQuarkAnalysis package and enables TopDecaySubset to process the new Pythia8 genparticles.
Since it was requested to preserve the previous functionality, the new code is only used if the new parameter,
runModeis set to 'Run2'.The changes were rebased upon the current master (CMSSW_7_4_X) but also work on CMSSW_7_0_9, CMSSW_7_2_X and CMSSW_7_3_X.
The code has been tested by two independent analysis groups on Spring14 (AOD) and Phys14 (miniAOD) samples.
Since this is my first CMSSW contribution since the github migration, please let me know if I am missing any steps in the procedure.