Workaround ICC bug.

[ktf]

CMSSW compiled with ICC reports a bunch of link errors of the kind:

tmp/slc6_amd64_gcc491/src/HLTrigger/Egamma/src/HLTriggerEgamma/HLTDisplacedEgammaFilter.o:(.data._ZTVN3edm6global8EDFilterIIEEE9HLTFilter__24HLTDisplacedEgammaFilter[_ZTVN3edm6global8EDFilterIIEEE9HLTFilter__24HLTDisplacedEgammaFilter]+0x18):
undefined reference to `edm::global::EDFilter<>::~EDFilter()'
tmp/slc6_amd64_gcc491/src/HLTrigger/Egamma/src/HLTriggerEgamma/HLTDisplacedEgammaFilter.o:(.data._ZTVN3edm6global8EDFilterIIEEE9HLTFilter__24HLTDisplacedEgammaFilter[_ZTVN3edm6global8EDFilterIIEEE9HLTFilter__24HLTDisplacedEgammaFilter]+0x20):
undefined reference to `edm::global::EDFilter<>::~EDFilter()'

and similar for other edm::global::EDFilter<> derived classes.

Notice edm::global::EDFilterBase, one of the two parent classes of edm::global::EDFilter<>, does have a virtual destructor, so I do believe this is actually a wrong behavior in ICC.

Swapping the order of parent classes in edm::global::EDFilter and adding an explicit virtual destructor there makes the problem disappear.

This is clearly not an acceptable solution, but so far I could not find anything else. This PR is just to keep track of the issue.

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Workaround ICC bug.

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlange6]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[davidlange6]

@cmsbuild, please test
(maybe the tests are stuck @ktf)

[nclopezo]

It had the

 Couldn't find remote ref refs/pull/7583/head 

issue. I restarted the tests using the branch name.

[ktf]

Can you please fail the test when that happens?

[cmsbuild]

+1
Tested at: b4a1c52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7583/2533/summary.html

[ktf]

+1
I think we agreed with @Dr15Jones the ifdef is fine.
On ven 13 feb 2015 at 04:21 cmsbuild notifications@github.com wrote:

+1
Tested at: e7299da
e7299da

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7583/2546/summary.html

—
Reply to this email directly or view it on GitHub
#7583 (comment).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1