ROOT does not use u or l qualifiers for integer template parameters in na...

[wmtan]

This is a bug fix to allow putting a ROOT SMatrix in an event, as requested by Slava Krutelyov.
ROOT does not use u or l qualifiers for the names of integer template parameters in class names. Because of this, a missing dictionary error resulted when attempting put an SMatrix into an event.
This pull request adds stripping off the "u" or "l" qualifiers in class names containing integer template parameters, thereby correcting the error.
This fix required the use of std::regex_replace(). Since we need regex_replace() anyway, two other existing CMSSW functions currently used to normalize class names were removed, as their usage is here being replaced by calls to std::regex_replace(). The usage of these functions was local to the one modified source file.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

ROOT does not use u or l qualifiers for integer template prameters in na...

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

Thank you, Bill.

I tried it with https://github.com/slava77/cmssw/blob/a702fac38b8ed2fd2a5c6d1667fc3d24fe9906de/RecoMET/METProducers/src/METSignificanceProducer.cc
and it works almost in full: I could save it and access from FWLite but only from the bare-bones data members
double22double2ROOTMathMatRepSymROOTMathSMatrix_METSignificance_METCovariance_PAT.obj.fRep.fArray[0]
.obj.At(0,0) gave me zeroes while the actual values are not zeroes

@mmarionncern

[Dr15Jones]

+1

[Dr15Jones]

Please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7586/2419/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[wmtan]

Note: This pull request is fine for 7_4_X, but the code changes for ROOT 6 are different.
Pull request #7607 is the code changes for the CMSSW_7_4_ROOT6_X branch.
Please do not attempt to merge this PR (#7568) into 7_4_ROOT6_X.

[davidlange6]

+1