Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DTCalibration FEB Path Correction #7600

Merged

Conversation

olschewski
Copy link
Contributor

Added a correction module to account for FEB path lengths.
It can run on t0 db files and outputs a corrected t0 db file.

Added a correction module to account for FEB path lengths.
It can run on t0 db files and outputs a corrected t0 db file.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

A new Pull Request was created by @olschewski for CMSSW_7_4_X.

Added DTCalibration FEB Path Correction

It involves the following packages:

CalibMuon/DTCalibration

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Feb 6, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

-1
Tested at: 6e51553
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 06-Feb-2015 22:09:13 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 160960
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module CtfSpecialSeedGenerator/'combinatorialcosmicseedfinderP5'
   [3] Using EventSetup component TkTransientTrackingRecHitBuilderESProducer/'ttrhbwr' to make data TransientTrackingRecHitBuilder/'WithTrackAngle' in record TransientRecHitRecord
   [4] Using EventSetup component StripCPEESProducer/'StripCPEfromTrackAngleESProducer' to make data StripClusterParameterEstimator/'StripCPEfromTrackAngle' in record TkStripCPERecord
   [5] Using EventSetup component TrackerDigiGeometryESModule/'trackerGeometryDB' to make data TrackerGeometry/'' in record TrackerDigiGeometryRecord
   [6] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record TrackerAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 06-Feb-2015 22:09:33 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 182124
   [1] Calling global beginRun for module DTTrigProd/'valDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 06-Feb-2015 22:10:01 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 06-Feb-2015 22:10:16 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Running path 'simulation_step'
   [2] Calling beginRun for module FamosProducer/'famosSimHits'
   [3] Using EventSetup component TrackerDigiGeometryESModule/'misalignedTrackerGeometry' to make data TrackerGeometry/'MisAligned' in record TrackerDigiGeometryRecord
   [4] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record TrackerAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 06-Feb-2015 22:10:21 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'local_digireco'
   [2] Calling event method for module MixingModule/'mix'
   [3] Using EventSetup component TrackerDigiGeometryESModule/'trackerGeometryDB' to make data TrackerGeometry/'' in record TrackerDigiGeometryRecord
   [4] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record TrackerAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 06-Feb-2015 22:10:20 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 191226
   [1] Calling global beginRun for module DTTrigProd/'valDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 06-Feb-2015 22:10:25 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 165121
   [1] Calling global beginRun for module DTTrigProd/'valDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 06-Feb-2015 22:10:37 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Running path 'simulation_step'
   [2] Calling beginRun for module FamosProducer/'famosSimHits'
   [3] Using EventSetup component TrackerDigiGeometryESModule/'misalignedTrackerGeometry' to make data TrackerGeometry/'MisAligned' in record TrackerDigiGeometryRecord
   [4] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record TrackerAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 06-Feb-2015 22:10:45 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 165121
   [1] Calling global beginRun for module DTTrigProd/'valDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 06-Feb-2015 22:11:01 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 194533
   [1] Calling global beginRun for module DTTrigProd/'valDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 06-Feb-2015 22:11:17 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 06-Feb-2015 22:22:02 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 06-Feb-2015 22:22:12 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 06-Feb-2015 22:22:28 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 06-Feb-2015 22:24:55 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling global beginRun for module DTTrigProd/'simDtTriggerPrimitiveDigis'
   [2] Using EventSetup component DTGeometryESModule/'' to make data DTGeometry/'' in record MuonGeometryRecord
   [3] Using EventSetup component PoolDBESSource/'GlobalTag' to make data AlignmentErrorsExtended/'' in record DTAlignmentErrorExtendedRcd
Exception Message:
A std::exception was thrown.
unsupported version
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7600/2432/summary.html

@mmusich
Copy link
Contributor

mmusich commented Mar 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants