Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74 Fireworks: support calo tower presentation for any reco::Candidate type #7608

Merged
merged 2 commits into from Feb 7, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Feb 6, 2015

Open inheritance from FWCandidateTowerProxyBuilder to any class derived from reco::Candidate (before it supported only PackedCandidate).

Make additional type check before instantiating a proxy builder.

@alja
Copy link
Contributor Author

alja commented Feb 6, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Feb 6, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2015

-1

Tested at: 1fbef18
I ran the usual tests and I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7608/2439/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 7, 2015
74 Fireworks:  support calo tower presentation for any reco::Candidate type
@davidlange6 davidlange6 merged commit 4a812c4 into cms-sw:CMSSW_7_4_X Feb 7, 2015
@alja alja deleted the 74-inherit branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants