New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ROSDebugUtility from DQM/DTMonitorModule. #7619
Conversation
ROSDebugUtility was only used to trigger thread-unsafe statics warnings and to waste cpu time. Also removed a few static variables from DTDataIntegrityTask, as they too didn't make any sense.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X. Remove ROSDebugUtility from DQM/DTMonitorModule. It involves the following packages: DQM/DTMonitorModule @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
The pull requests comment made me laugh :). Thanks for the fix. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Remove ROSDebugUtility from DQM/DTMonitorModule.
ROSDebugUtility was only used to trigger thread-unsafe statics
warnings and to waste cpu time.
Also removed a few static variables from DTDataIntegrityTask,
as they too didn't make any sense.
(Fixes static warnings from #7510)