Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ROSDebugUtility from DQM/DTMonitorModule. #7619

Merged
merged 1 commit into from Feb 9, 2015

Conversation

dmitrijus
Copy link
Contributor

ROSDebugUtility was only used to trigger thread-unsafe statics
warnings and to waste cpu time.

Also removed a few static variables from DTDataIntegrityTask,
as they too didn't make any sense.

(Fixes static warnings from #7510)

ROSDebugUtility was only used to trigger thread-unsafe statics
warnings and to waste cpu time.

Also removed a few static variables from DTDataIntegrityTask,
as they too didn't make any sense.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2015

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X.

Remove ROSDebugUtility from DQM/DTMonitorModule.

It involves the following packages:

DQM/DTMonitorModule

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

The pull requests comment made me laugh :). Thanks for the fix.

@deguio
Copy link
Contributor

deguio commented Feb 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@deguio
Copy link
Contributor

deguio commented Feb 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 9, 2015
Remove ROSDebugUtility from DQM/DTMonitorModule.
@cmsbuild cmsbuild merged commit fbe3734 into cms-sw:CMSSW_7_4_X Feb 9, 2015
kpedro88 added a commit to kpedro88/cmssw that referenced this pull request Apr 4, 2017
kpedro88 added a commit to kpedro88/cmssw that referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants