Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCal digitisation changes to the run2 era #7676

Merged

Conversation

mark-grimes
Copy link

Adds the Run 2 customisations from customisePostLS1 relevant to the HCal digitisation (the ten or so lines starting here) to the run2 era. No changes are made unless the run2 era is explicitly activated.

Testing has been limited. I just checked that the particular modules have the changes applied when the era is activated. If it's not activated then there is no change. I'll worry about confirming identity between the two methods (customisation versus era) once all the pull requests are in.

I haven't taken the customisations out of the run2 helper function customiseRun2EraExtras. The postLS1Customs.py file is being heavily modified by #7579, and this would likely cause a conflict. Applying the modification twice has no harm (well, event content commands are added twice but I think that's harmless) so I'll remove those lines in a later pull request. It's only temporary anyway.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Add HCal digitisation changes to the run2 era

It involves the following packages:

SimCalorimetry/Configuration
SimCalorimetry/HcalSimProducers

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

bypassing era PRs - lets discuss once Mark has the full set implemented - currently they have no effect

davidlange6 added a commit that referenced this pull request Feb 12, 2015
Add HCal digitisation changes to the run2 era
@davidlange6 davidlange6 merged commit 153109b into cms-sw:CMSSW_7_4_X Feb 12, 2015
@mark-grimes mark-grimes deleted the convertPostLS1ToEra_hcalDigi branch August 3, 2015 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants