Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL #7679

Merged
merged 1 commit into from Feb 24, 2015
Merged

UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL #7679

merged 1 commit into from Feb 24, 2015

Conversation

connorpa
Copy link
Contributor

  • checked the behaviour of the TGraph and TMultiGraph
  • checked the colours
  • fixed the max and min options
  • added grids
  • added comments and debug options into code
  • increased png resolution (and file weight, but there is a neww option to fix the size of the canvas)

@connorpa
UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL
6cab481 
- checked the behaviour of the TGraph and TMultiGraph
- checked the colours
- fixed the max and min options
- added grids
- added comments and debug options into code
- increased png resolution (and file weight, but there is a neww option to fix the size of the canvas)
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Feb 11, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @connorpa for CMSSW_7_4_X.

UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Feb 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6cab481
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7679/2632/summary.html

@cmsbuild cmsbuild mentioned this pull request Feb 17, 2015
Merged
@mmusich
Copy link
Contributor

mmusich commented Feb 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 24, 2015
@cmsbuild
Merge pull request #7679 from connorpa/GeometryComparisonPlotter
bcf11c3 
UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL
@cmsbuild cmsbuild merged commit bcf11c3 into cms-sw:CMSSW_7_4_X Feb 24, 2015
hroskes pushed a commit to hroskes/cmssw that referenced this pull request Sep 1, 2015
@cmsbuild @hroskes
Merge pull request cms-sw#7679 from connorpa/GeometryComparisonPlotter
28c9638 
UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL
hroskes pushed a commit to hroskes/cmssw that referenced this pull request Sep 1, 2015
@cmsbuild @hroskes
Merge pull request cms-sw#7679 from connorpa/GeometryComparisonPlotter
3d66b9f 
UPDATE OF GEOMETRY COMPARISON PLOTTER TOOL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@connorpa @cmsbuild @mmusich @davidlange6