Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-hgx27 (HE Rebuild integrated with HGCAL) #7695

Merged
merged 1 commit into from Feb 16, 2015

Conversation

bsunanda
Copy link
Contributor

The geometry codes for Hcal, several cfi/cff files and the validation code for HGCal is modified to go upto Digi stage for HGCAL with HE rebuild. Subsequent steps are needed in PFlow code.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

bsunanda:Phase2-hgx27 (HE Rebuild integrated with HGCAL)

It involves the following packages:

Geometry/CaloEventSetup
Geometry/FCalGeometry
Geometry/HcalCommonData
Geometry/HcalTowerAlgo
Validation/HGCalValidation
Validation/HcalHits

The following packages do not have a category, yet:

Geometry/FCalGeometry
Validation/HGCalValidation

@civanch, @Dr15Jones, @danduggan, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @deguio, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fratnikov
Copy link

Looks like we have a problem on DIGI step:
Begin processing the 2nd record. Run 1, Event 2, LumiSection 1 at 12-Feb-2015 16:41:43.558 CET
%MSG-e HGCDigitizer: MixingModule:mix 12-Feb-2015 16:41:43 CET Run: 1 Event: 2
@ accumulate : can't find HGCHitsHEback collection of g4SimHits

@bsunanda
Copy link
Contributor Author

This is not a problem. This is a false warning. I shall remove this warning at some later stage. For V6 HGCal geometry there is no HGCHitsHEback and this is replaced by standard Hcal HE hits. I tested that using the HGcal validation tools.


From: Fedor Ratnikov [notifications@github.com]
Sent: 12 February 2015 20:09
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Phase2-hgx27 (HE Rebuild integrated with HGCAL) (#7695)

Looks like we have a problem on DIGI step:
Begin processing the 2nd record. Run 1, Event 2, LumiSection 1 at 12-Feb-2015 16:41:43.558 CET
%MSG-e HGCDigitizer: MixingModule:mix 12-Feb-2015 16:41:43 CET Run: 1 Event: 2
@ accumulate : can't find HGCHitsHEback collection of g4SimHits


Reply to this email directly or view it on GitHubhttps://github.com//pull/7695#issuecomment-74131916.

@fratnikov
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@fratnikov
Copy link

merge

cmsbuild added a commit that referenced this pull request Feb 16, 2015
bsunanda:Phase2-hgx27  (HE Rebuild integrated with HGCAL)
@cmsbuild cmsbuild merged commit 044fe4a into cms-sw:CMSSW_6_2_X_SLHC Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants