add missing std:: namespace qualifiers #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. add missing std:: namespace qualifiers It involves the following packages: IOPool/Streamer @Dr15Jones, @ktf can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
|
Hi, I ran the usual tests on top of CMSSW_7_0_X_2013-09-11-0200, all tests passed: you can see the artifacts here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/447 |
ktf
added a commit
that referenced
this pull request
Sep 11, 2013
add missing std:: namespace qualifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the framework against ROOT 6, I noticed some compilation errors in IOPool/Streamer because "ifstream" was used, instead of "std::ifstream". I have no idea why this compiled before, because I can't find any relevant using directives or declarations. So, this pull request adds any missing "std::" namespace qualifiers to instances of ifstream, vector, string, cout, endl, etc. that I could find in IOPool/Streamer.
In a couple of places, I also took multiple statements on the same line and put them on separate lines.