Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for consumes interface in SimGeneral/MixingModule #7885

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 20, 2015

SimGeneral/MixingModule will consume a vector of SimTrack or SimVertex whether or not it is producing a CrossingFrame. So, the consumes calls for these are in the wrong place. This is a fix for the bug, and allows the consumes interface to function properly.

@wmtan wmtan changed the title Fix for copnsumes interface in SimGeneral/MixingModule Fix for consumes interface in SimGeneral/MixingModule Feb 20, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Feb 20, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Fix for consumes interface in SimGeneral/MixingModule

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Feb 21, 2015
Fix for consumes interface in SimGeneral/MixingModule
@davidlange6 davidlange6 merged commit 4e4b14b into cms-sw:CMSSW_7_5_X Feb 21, 2015
@cmsbuild
Copy link
Contributor

@wmtan wmtan deleted the ConsumesSimGeneralMixingModule branch February 21, 2015 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants