Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VtxSmearing for pPb to fix a failing IB test #7927

Merged
merged 2 commits into from Mar 24, 2015

Conversation

kkrajczar
Copy link
Contributor

Workflow 280.0 is failing in the IB tests both in 74X and in 75X with the error "KeyError: 'Realistic8TeVCollisionPPbBoost'". Indeed, Realistic8TeVCollisionPPbBoost is no longer defined in https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/Configuration/StandardSequences/python/VtxSmeared.py. After discussing the issue with @yetkinyilmaz we understand that the vtx smearing should be changed to Realistic5TeVPPbBoost; which is the purpose of this PR.

The proposed change was tested to fix workflow 280.0.

@BetterWang, @yetkinyilmaz, @mandrenguyen

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_4_X.

Change VtxSmearing for pPb to fix a failing IB test

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@kkrajczar
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants