Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated defaut PAT jet b-taggers #7992

Conversation

ferencek
Copy link
Contributor

Now that CMSSW_7_4_0_pre8 RelVals are available, the list of default PAT jet b-taggers has been updated. This PR completes the changes introduced in #7542, #7678, and #7732.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Updated defaut PAT jet b-taggers

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex
TopQuarkAnalysis/Configuration

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 1, 2015

+1

For [#7992] 91190e7

This PR makes a tiny change to Reco code to change an unnecessary copying of a vector to a const reference instead, and also alters Analysis code to update the list of default PAT b-jet taggers and RelVal input.

For Reco:

The code changes are satisfactory.

Jenkins tests CMSSW_7_4_X_2015-02-27-0200:
compilation, unit tests, matrix tests, static checks are all OK.

As expected, there are no significant differences compared to the baseline in the
following:

alternative-comparisons
(after stripping false positives like timer data)

and

validateJR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants