Fixed btagging sequence definition

[ferencek]

The btagging sequence is now explicitly defined as a cms.Sequence(...). It turns out that if it is not, process.load("RecoBTag.Configuration.RecoBTag_cff") does not load and add it to the process.

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Fixed btagging sequence definition

It involves the following packages:

RecoBTag/Configuration

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

Hi Dinko,

where does this become an issue? (rerunning btagging only in a standalone configuration seems the only obvious case, but maybe there are more).

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[ferencek]

@slava77 The problem appeared with a private cfg file that loads and re-runs the standard b-tagging sequence. A student noticed that his cfg file, that worked just fine in 73X, stopped working in 74X with the following error message

AttributeError: 'Process' object has no attribute 'btagging'

even though

process.load("RecoBTag.Configuration.RecoBTag_cff")

was present in the cfg file. After some investigation, I realized what was causing the problem. However, I can't claim I fully understand the problem, I just figured out how to fix it. As far as I can tell, in all other places in CMSSW where

process.load("RecoBTag.Configuration.RecoBTag_cff")

is present, it is not used to run the standard b-tagging sequence but for other reasons. Instead, for the standard reconstruction the sequence is loaded using

from RecoBTag.Configuration.RecoBTag_cff import *

which was unaffected by the change in the way the sequence was defined, and that's why the problem went unnoticed.

[cmsbuild]

+1
Tested at: e27145d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7995/2985/summary.html

[slava77]

+1

for #7995 e27145d

the change is somewhat trivial and jenkins tests are OK.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1