Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ntuplizer for pixel hits #8021

Merged

Conversation

emiglior
Copy link
Contributor

@emiglior emiglior commented Mar 2, 2015

Added a simple EDA for writing user ntuple with the pixel RecHit infos for SLHC studies.
It is essentially a developement of SLHCUpgradeSimulations/Geometry/test/StdHitNtuplizer[.h,.cc] but limited to pixels only.
@ktf, @davidlt
@boudoul, @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2015

A new Pull Request was created by @emiglior (Ernesto Migliore) for CMSSW_6_2_X_SLHC.

add ntuplizer for pixel hits

It involves the following packages:

SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Mar 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

@emiglior
Copy link
Contributor Author

emiglior commented Mar 3, 2015

@cmsbuild please notice changes in BuildFile

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

Pull request #8021 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@emiglior
Copy link
Contributor Author

emiglior commented Mar 4, 2015

@boudoul, @ianna, @mmusich
Hi,
I have two questions:

  • who is going to sign the PR?
  • should we forward-port this analyzer to CMSSW_75X?

@emiglior
Copy link
Contributor Author

emiglior commented Mar 4, 2015

@atricomi this is something that you might want to monitor as well

@boudoul
Copy link
Contributor

boudoul commented Mar 4, 2015

hi @emiglior , the release managers of the SLHC release willl take care at their convenance - It would be good indeed to have this analyzer ready in 75X - We probably cannot test it in 75X at this point, but keeping things synchronized is good , can you prepare a PR for 75X too ? Thanks.

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Mar 6, 2015
@cmsbuild cmsbuild merged commit 4c72c43 into cms-sw:CMSSW_6_2_X_SLHC Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants