Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic pandora track cleaning #8023

Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Mar 3, 2015

@kpedro88 submitting this PR for @lgray. Cuts on delta_pt/pt were added for the Pandora PF objects to reject misreconstructed tracks. These cuts had the desired effect of removing jets/charged hadrons with unphysically high energies.

Before:
pfjetenergy_before_deltapt_cut

After:
pfjetenergy_after_deltapt_cut

Please include this PR in the release with the other HGCal Pandora PRs. This is important for physics performance.

Attn: @vandreev11 @pfs @sethzenz

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

Topic pandora track cleaning

It involves the following packages:

RecoBTag/SoftLepton
RecoParticleFlow/PandoraTranslator

The following packages do not have a category, yet:

RecoParticleFlow/PandoraTranslator

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @imarches, @acaudron, @lgray, @ferencek, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

@mark-grimes
Copy link

merge

As well as the automatic tests, I tried 15600 and 15800 (Pandora reconstruction for 0 and 140 pileup respectively). 15600 completed fine, 15800 failed but it was xrootd errors on the minimum bias files, which I'm going to assume is transitory.

cmsbuild added a commit that referenced this pull request Mar 3, 2015
@cmsbuild cmsbuild merged commit 6dc68e8 into cms-sw:CMSSW_6_2_X_SLHC Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants