Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of the new SiPhase2Clusterizer in CMSSW #8032

Merged
merged 2 commits into from Mar 9, 2015
Merged

Integration of the new SiPhase2Clusterizer in CMSSW #8032

merged 2 commits into from Mar 9, 2015

Conversation

thomaslenzi
Copy link
Contributor

Updated version of the Outer Tracker Clusterizer for the Phase2 Upgrade Simulations:

  • Using new data format previously merged in CMSSW
  • Optimised algorithm
  • Clearer naming convention
  • Cleaned up code

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

A new Pull Request was created by @thomaslenzi (Thomas Lenzi) for CMSSW_6_2_X_SLHC.

Integration of the new SiPhase2Clusterizer in CMSSW

It involves the following packages:

SLHCUpgradeSimulations/Configuration
SimTracker/SiPhase2Digitizer

The following packages do not have a category, yet:

SimTracker/SiPhase2Digitizer

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

// Objects that will be produced
produces< Phase2TrackerCluster1DCollectionNew >();
//
clusterizer_ = new Phase2TrackerClusterizerAlgorithm(maxClusterSize_, maxNumberClusters_);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This memory is never released. Either change clusterizer_ to a std::unique_ptr or delete it in the destructor.

@mark-grimes
Copy link

merge

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

Pull request #8032 was updated. @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please check and sign again.

cmsbuild added a commit that referenced this pull request Mar 9, 2015
Integration of the new SiPhase2Clusterizer in CMSSW
@cmsbuild cmsbuild merged commit 79914cf into cms-sw:CMSSW_6_2_X_SLHC Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants