Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug (related to dxy;el/mu+other case) and add the 3rd highest pt m... #8058

Merged
merged 1 commit into from Mar 6, 2015

Conversation

ryonamin
Copy link

@ryonamin ryonamin commented Mar 4, 2015

There are two independent modifications.

  1. bug fix related to dxy plot
    We found that we get an error in specific cases in which trigger path has electron/muon objects and
    additionally other objects (e.g. photons).
    The problem was caused by
    HLTriggerOffline/Exotica/src/HLTExoticaPlotter.cc, line:148.
    Previously we tried to fill even for non-electron/muon object because the condition (dxys.size() >0) is satisfied.
    So now we fill the histograms only if the object is electron/muon.

  2. add the 3rd highest Pt plot (the other changes)
    This is a request from a trigger developer.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @ryonamin for CMSSW_7_5_X.

fix a bug (related to dxy;el/mu+other case) and add the 3rd highest pt m...

It involves the following packages:

HLTriggerOffline/Exotica

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@deguio
Copy link
Contributor

deguio commented Mar 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants