Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make char arrays fully const in TaggingVariable #8078

Conversation

Dr15Jones
Copy link
Contributor

The globally available arrays of names are now fully const. This
was spotted by the static analyzer.

The globally available arrays of names are now fully const. This
was spotted by the static analyzer.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Make char arrays fully const in TaggingVariable

It involves the following packages:

DataFormats/BTauReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 5, 2015

+1

For #8078 154fa13

This PR makes a very minor code change to make constant the pointers in some const arrays. It should not change any behavior, as long as no code is changing the pointers.

Jenkins tests results are clean, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants