Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal geometry #809

Merged
merged 2 commits into from Sep 17, 2013
Merged

Hcal geometry #809

merged 2 commits into from Sep 17, 2013

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 12, 2013

  • Migrate code changes from CVS
  • Remove obsolete file

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Hcal geometry

It involves the following packages:

Geometry/HcalTowerAlgo
CondTools/Geometry

@ggovi, @apfeiffer1, @Dr15Jones, @ianna, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1
thanks, David, for running the tests !

@ianna
Copy link
Contributor Author

ianna commented Sep 16, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 17, 2013
@ktf ktf merged commit 0ca9161 into cms-sw:CMSSW_7_0_X Sep 17, 2013
@ianna ianna deleted the hcal-geometry branch October 26, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants