Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root6 version numbers should be known to Root5. (Core) #8105

Merged
merged 1 commit into from Mar 7, 2015
Merged

Root6 version numbers should be known to Root5. (Core) #8105

merged 1 commit into from Mar 7, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 5, 2015

Root6 class version numbers should be known to ROOT5. This prevents serious problems.
This PR is for the affected classes in the Core software category.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Mar 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Root6 version numbers should be known to Root5. (Core)

It involves the following packages:

DataFormats/Common
DataFormats/Provenance
DataFormats/Streamer
FWCore/Common

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

Pull request #8105 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

+1
Tested at: e1921c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8105/3149/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8105/3149/summary.html

davidlange6 added a commit that referenced this pull request Mar 7, 2015
@davidlange6
Merge pull request #8105 from wmtan/ConsumesCore75X
5a66d74 
Root6 version numbers should be known to Root5. (Core)
@davidlange6 davidlange6 merged commit 5a66d74 into cms-sw:CMSSW_7_5_X Mar 7, 2015
@wmtan wmtan deleted the ConsumesCore75X branch March 8, 2015 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wmtan @cmsbuild @Dr15Jones @davidlange6