Migration to consumes -- EGamma DQM

[nkellams]

updating photon DQM to use getByToken and consume as outlined in the DQM meeting

[cmsbuild]

A new Pull Request was created by @nkellams for CMSSW_7_0_X.

Dqm egamma consumes patch

It involves the following packages:

DQMOffline/EGamma

@danduggan, @rovere, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[deguio]

if you remove this parameter you brake the sequence: DQMOfflineHeavyIonsPrePOG
defined in
DQMOffline/Configuration/python/DQMOfflineHeavyIons_cff.py

you have to either put back the parameter or you adapt the sequence.

[deguio]

@nkellams you can update the code and push the changes to this pull request.
I leave it pending for now.

thanks,
F.

[deguio]

@nkellams
any news on this?

thanks,
F.

@rovere

[nkellams]

I put the parameters back in so that the DQMOfflineHeavyIons_cff.py would not complain. However, now I get warnings about those parameters being depricated. Is it acceptable to have these warnings?

[cmsbuild]

Pull request #812 was updated. @danduggan, @nclopezo, @rovere, @deguio can you please check and sign again.

[nclopezo]

+1
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/590/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/590

[ktf]

Please do not introduce new warnings.

[nkellams]

Hi All,
I'm rather confused about this. I had to change these parameters from strings to inputTags to comply with the need to use getByToken (which does not take strings) instead of getByLabel (which did take strings) as discussed in the DQM meetings. Doing so broke the HeavyIon file mentioned above. I put back these parameters, even though they are unused in the EGamma software now so that the HeavyIon file wouldn't complain. This gives me warnings to use inputTags instead of strings, which is why I originally removed them. Given that I am not a developer of the HeavyIon DQM software I don't see how to resolve this issue without the warnings.

[deguio]

hello @nkellams
have a look at:
https://cmssdt.cern.ch/SDT/lxr/source/DQMServices/Components/plugins/DQMLumiMonitor.cc?v=CMSSW_7_0_0_pre4#031
it seems to me that it is still possible to use strings with the getByToken. I didn't get any warning when I did that but I leave @ktf comment about what is better to use.

As you can imagine we cannot integrate changes that brake the existing code. that is the reason why we ask the developers to test the code before submitting a pull request.

I see 2 solutions:

• if the use of the strings is blessed by @ktf then we can forget about the inputTags
• we use the inputTags and we can modify the HI code accordingly making sure that everything is consistent. this is possible with GIT. you don't have to be a "HI developer" to do so.

Of course I can help if needed.

thanks,
F.

@rovere @dandaggan

[ktf]

I would go for the second solution and do a proper cleanup.

[cmsbuild]

Pull request #812 was updated. @smuzaffar, @nclopezo, @danduggan, @rovere, @deguio, @eliasron can you please check and sign again.

[nclopezo]

+1
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/653/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/653

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?