Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniAOD lepton updates (74X) #8156

Merged
merged 6 commits into from Mar 11, 2015
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Mar 9, 2015

  • adding the PF Ecal energy to the pat::Muon, needed for collinear FSR recovery (in the AOD this can be accessed from the full reco::PFCandidate, but in minAOD the packed PF candidate doesn't contain this info)
  • removing duplicate copies of the impact parameter, and storing them as floats instead of doubles. Just like before, the lepton has IP info both computed wrt the PV and wrt the beamSpot (though the 3D impact paramtere wrt the beam-spot IMHO makes no sense).
  • ioread rules are implemented for this impact parameter change, and tested reading 7.2.X from 7.4.0.pre8

Still investigating two other minor but orthogonal points, one if the numberOfHits can be removed ( https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3316.html ), and whether the muon HO energy should be added.

A 75X request will also be added

@arizzi

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_4_X.

MiniAOD lepton updates (74X)

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Mar 11, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants