increase tollerance to make space for shifted FPIX

[VinInn]

took the opportunity to upgrade to c++11

[VinInn]

Have not run tests...
if ok, we will port to 74x and 75x

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_3_X.

increase tollerance to make space for shifted FPIX

It involves the following packages:

RecoTracker/TkNavigation

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[VinInn]

@cmsbuild , please test
when done it should be forward ported.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[diguida]

@VinInn @mmusich
thanks for the fix!
@frmeier @tlampen this is something interesting for FPIX alignment

[frmeier]

@VinInn
thanks for the fix. Wouldn't it be worth to have the limits configurable, default would be 1 and 2 cm, respectively? Or too much overload? Your are in a better position to judge.
@diguida, @mmusich thanks for pointing us to it.

[VinInn]

difficult to percolate a config in this place.
If we need to fix, we simply have to build left and right independently.
Easy to do, long to debug and validate...

[davidlange6]

@nclopezo - could you restart these tests? They seem stuck

[nclopezo]

ok, I restarted them.

[cmsbuild]

-1
Tested at: 3c7c54f
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8174/3283/summary.html

[cmsbuild]

-1
Tested at: 3c7c54f
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8174/2360/summary.html

[slava77]

+1

for #8174 3c7c54f

tested in CMSSW_7_4_0_pre8 /test area sign527, with a cherry-pick/
with higher statistics samples comparisons show no differences in monitored quantities (expected result for the MC/data used in the tests)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar