Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning for QIEXXDataFrames (Backport of #8206) #8207

Merged
merged 1 commit into from Mar 14, 2015

Conversation

agude
Copy link

@agude agude commented Mar 11, 2015

This fixes the compiler warnings introduced in #8103 (see #8103 (comment)) and is a backport of #8206.

Additionally we have done the following:

Replace "magic numbers" with constants
Add "flag" word which will inevitably be required operationally
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @agude (Alexander Gude) for CMSSW_7_4_X.

Fix compiler warning for QIEXXDataFrames (Backport of #8206)

It involves the following packages:

DataFormats/HcalDigi

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@agude - thanks - is there a 73x version coming as well? Would be good to be able to include in the next 73x release.

@agude
Copy link
Author

agude commented Mar 11, 2015

Hi @davidlange6,

Since the 7_3 PR (#8013) hasn't been merged yet, I just pushed an update there instead of opening a whole new PR: #8013 (comment)

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 14, 2015
Fix compiler warning for QIEXXDataFrames (Backport of #8206)
@davidlange6 davidlange6 merged commit a327776 into cms-sw:CMSSW_7_4_X Mar 14, 2015
@agude agude deleted the 7_4_qie_patch branch March 18, 2015 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants