Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary ROOT5/ROOT6 difference in SimDataFormats/PileupSummar... #8233

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 12, 2015

This PR is part of a campaign to remove unnecessary differences in CMSSW between 7_4_X and 7_4_ROOT6_X. In this particular case, the 7_4_ROOT6_X build file is superior to the 7_4_X build file, in that it avoids unnecessary dependencies. So, in this case, it is 7_4_X that is being updated.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Remove unnecessary ROOT5/ROOT6 difference in SimDataFormats/PileupSummar...

It involves the following packages:

SimDataFormats/PileupSummaryInfo

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Mar 13, 2015

+1

@civanch
Copy link
Contributor

civanch commented Mar 13, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild added a commit that referenced this pull request Mar 14, 2015
…aryInfo

Remove unnecessary ROOT5/ROOT6 difference in SimDataFormats/PileupSummar...
@cmsbuild cmsbuild merged commit c6e338e into cms-sw:CMSSW_7_4_X Mar 14, 2015
@wmtan wmtan deleted the ReconcileSimDataFormatsPileupSummaryInfo branch March 17, 2015 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants