Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove friendship relations to removed DaqSource. #824

Merged
merged 1 commit into from Sep 13, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Sep 13, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Remove friendship relations to removed DaqSource.

It involves the following packages:

FWCore/Common
FWCore/Framework

@Dr15Jones, @ktf can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor Author

ktf commented Sep 13, 2013

cc @emeschi as well...

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

Hi,

I ran the tests con jenkins, and when compiling I got the following error:

In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/include/c++/4.8.1/cassert:43:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-09-13-0200/src/DataFormats/Common/interface/PtrVectorBase.h:27,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-09-13-0200/src/DataFormats/Common/interface/PtrVector.h:24,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-09-13-0200/src/DataFormats/Common/interface/Wrapper.h:12,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-09-13-0200/src/DataFormats/Common/interface/ConvertHandle.h:6,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/src/FWCore/Framework/interface/Principal.h:21,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/src/FWCore/Framework/interface/EventPrincipal.h:22,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/src/FWCore/Framework/src/EventPrincipal.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/src/FWCore/Framework/src/EventPrincipal.cc: In member function 'void edm::EventPrincipal::put(const edm::BranchDescription&, const edm::WrapperOwningHolder&, const edm::ProductProvenance&)':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/src/FWCore/Framework/src/EventPrincipal.cc:116:21: error: 'produced' was not declared in this scope
     assert(produced());

you can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/500/console

@ktf
Copy link
Contributor Author

ktf commented Sep 13, 2013

Thanks for spotting this, not sure why it worked in my area. I'll make the
patch minimal and comment it again.

@ktf
Copy link
Contributor Author

ktf commented Sep 13, 2013

+1

ktf added a commit that referenced this pull request Sep 13, 2013
Remove friendship relations to removed DaqSource.
@ktf ktf merged commit ab3833b into cms-sw:CMSSW_7_0_X Sep 13, 2013
@ktf ktf deleted the remove-friend-daqsource branch September 13, 2013 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants