Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi into mini aod #8249

Merged
merged 17 commits into from Mar 15, 2015
Merged

Puppi into mini aod #8249

merged 17 commits into from Mar 15, 2015

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Mar 13, 2015

added puppi jet collection and puppi met into miniAODs

added jet charge, btagging, secondary vertex info and daughter links for puppi jets

added puppi weights as packed 8 bit into packcandidates

removed labels in puppi producer since only three different types of objects are produced

fixed the packing for liblogintpack, negative values were being lost

updated PackedCandidate ClassVersion to 17

added new iputs to PATPackedCandidateProducer, (PuppiWeight, PuppiCandsMap and PuppiCands) to save puppi weights into packcandidates and ValueMap for puppi to be able to map back to the puppi candidates from puppi jets to packcandidates

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_7_4_X.

Puppi into mini aod

It involves the following packages:

CommonTools/PileupAlgos
DataFormats/PatCandidates
PhysicsTools/PatAlgos

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2015

Jason,
please add a bit longer description for this change (at the top of this thread, by editing the first message), maybe add a link to slides or other details if they exist.
Thanks

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@arizzi
Copy link
Contributor

arizzi commented Mar 13, 2015

please note that @gpetruc just spotted that the daughters rekeying is actually broken (running but refs point a bit random)... we will provide a fix asap

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants