Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two remaining unnecessary direct dependencies on rootrflx #8281

Merged
merged 1 commit into from Mar 14, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 13, 2015

Since virtually everything has an indirect dependency on rootrflx through DataFormats/Math or DataFormats/DetId, Giulio recently removed explicit link dependencies on rootrflx from many BuildFiles so as to remove BuildFile differences between CMSSW_7_4_X and CMSSW_7_4_ROOT6_X. I discovered two additional BuildFiles in which this explcit dependency can be removed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Remove two remaining unnecessary direct dependencies on rootrflx

It involves the following packages:

DataFormats/TrackingRecHit
SimDataFormats/Associations

The following packages do not have a category, yet:

SimDataFormats/Associations

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2015

@cmsbuild please test

I also made cms-sw/cms-bot#387 to resolve the new-package-pending

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants