HLT Module for Saving DIGIs of Rechits for Pi0/Eta Calibration Stream [74X]

[hardenbr]

No description provided.

[cmsbuild]

A new Pull Request was created by @hardenbr for CMSSW_7_4_X.

HLT Module for Saving DIGIs of Rechits for Pi0/Eta Calibration Stream [74X]

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[fwyzard]

No, just no. Please use simply "region" or "regionId" or whatever, as the parameter name.

You can use strings ("EE" / "EB" or "endcap" / "barrel" or whatever you prefer) and covert them integers (better, an enum) in a helper function.
Or, plain integers as you are using, and add a comment in the cfi file explaining the meaning.

[cmsbuild]

+1
Tested at: 284d6d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8311/3513/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1