L3 code update march2015 #8356

BenjaminRS · 2015-03-17T13:52:15Z

Hello all,

Here is the updated code that we wish to have in place in order to allow for the new L3 reconstruction. It comes in the PR instead of #7810. The modified code will need adjustments to be made in the configuration menu for the following modules:
process.hltL3MuonsOIState
process.hltL3MuonsOIHit
process.hltL3TrajSeedIOHit
process.hltL3MuonsIOHit

Also in the later menus the versions of these modules with no filters if present. Do I add the configurations as an attachment to this PR?

The configurations need to be updated as the compilation will complain during validation that "Illegal parameters found in configuration". I.e. we do not use the extra parameters anymore if I change the input variables in the code. If I don't change the input variables then exceptions of the type "X should be defined as Y" would appear. So in this case the configuration menus need to change along with the modified code.

Thanks,
Benjamin

cmsbuild · 2015-03-17T13:58:35Z

A new Pull Request was created by @BenjaminRS (Benjamin Radburn-Smith) for CMSSW_7_5_X.

L3 code update march2015

It involves the following packages:

FastSimulation/Muons
HLTrigger/Muon
RecoHI/HiMuonAlgos
RecoMuon/GlobalTrackingTools
RecoMuon/L3TrackFinder
RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @civanch, @nclopezo, @lveldere, @cvuosalo, @fwyzard, @ssekmen, @mdhildreth, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @trocino, @abbiendi, @MiheeJo, @jhgoh, @dgulhan, @appeltel, @bellan, @richard-cms, @yenjie, @jazzitup, @echapon, @kurtejung, @matt-komm, @yetkinyilmaz, @mandrenguyen, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Martin-Grunewald · 2015-03-17T14:04:34Z

If you change parameters, then you either need to update the fillDescriptions(.) method
of the class, or, if the plugin does not have a fillDescriptions, the module's cfi file
in the python directory.

Martin-Grunewald · 2015-03-17T14:05:11Z

Once this is there, it would require a ConfDB parsing for the HLT.

lveldere · 2015-03-17T15:59:11Z

FastSimulation/Muons/plugins/FastTSGFromL2Muon.cc

@@ -49,8 +49,9 @@ FastTSGFromL2Muon::beginRun(edm::Run const& run, edm::EventSetup const& es)
  edm::ParameterSet regionBuilderPSet = 
    theConfig.getParameter<edm::ParameterSet>("MuonTrackingRegionBuilder");
  edm::ConsumesCollector iC  = consumesCollector();
-  theRegionBuilder = new MuonTrackingRegionBuilder(regionBuilderPSet,theService,iC);


@BenjaminRS

Hi Benjamin

I assume you know what you're doing, cause I'm not familiar with this code. :-)

Would you mind removing theService from this class.
It's not used anymore after your change.

Thanks

Lukas

Hi Lukas,

We changed the MuonTrackingRegionBuilder, so now it no longer uses the MuonServiceProxy. Although there are still calls to updating the theService in FastTSGFromL2Muon::beginRun and FastTSGFromL2Muon::produce, I guess they are not used by anything else? In which case, yes theService could be removed.

Thanks,
Benjamin

BenjaminRS · 2015-03-17T16:05:58Z

Hi Martin. I cannot use the fillDescription of the class as mentioned in the first message (due to two types of exception message depending on the way I try to solve the issue of using new variables). I will look into using the cfi file.

Martin-Grunewald · 2015-03-17T16:10:07Z

Hi,

I do not understand your comment. fillDescriptions must always work - it may at most be technically complicated if there are a lot of subclasses which do their own parameters.
Note: the module behavior MUST not depend on whether a certain parameter is
present in the py config or not - only it's value!
Hence we have a unique set of parameters (at least at top level) for each module,
which are always present in all configured instances, all have values, but of course
some may be unused depending on the value of some other parameter!

cmsbuild · 2015-03-18T16:42:49Z

-1
Tested at: bae48d5
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 18-Mar-2015 17:24:41 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SeedGeneratorFromRegionHitsEDProducer label='hiRegitMuInitialStepSeeds'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 18-Mar-2015 17:24:46 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 18-Mar-2015 17:25:02 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 18-Mar-2015 17:25:03 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 18-Mar-2015 17:25:03 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 18-Mar-2015 17:25:09 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 18-Mar-2015 17:25:45 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Mar-2015 17:26:27 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L3MuonProducer label='hltL3MuonsOIState'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Mar-2015 17:33:58 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L3MuonProducer label='hltL3MuonsOIState'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 18-Mar-2015 17:39:06 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 18-Mar-2015 17:40:44 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Mar-2015 17:41:18 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L3MuonProducer label='hltL3MuonsOIState'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15+MINIAODMCUP1550.log
----- Begin Fatal Exception 18-Mar-2015 17:41:49 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L3MuonProducer label='hltL3MuonsOIState'
Exception Message:
MissingParameter: Parameter 'Z_fixed' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8356/7179/summary.html

Martin-Grunewald · 2015-03-23T06:56:35Z

What is the fate of this PR? Benjamin, are you pushing this or not?

If so: make the fillDescriptions as above (or at least update the cfi file for
each module for the new and final parameters) and let me know in detail
what needs to be changed in terms of module parameters and values
for those for HLT use.
I assume the default configuration would be to reproduce the old behavour.
Switching to the new behaviour requires TSG approval.

cmsbuild · 2015-05-18T14:13:12Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

davidlange6 · 2015-05-18T14:17:26Z

+1

L3 code update march2015

cmsbuild added this to the Next CMSSW_7_5_X milestone Mar 17, 2015

cmsbuild added comparison-pending fastsim-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 17, 2015

lveldere reviewed Mar 17, 2015
View reviewed changes

cmsbuild added comparison-pending fastsim-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-rejected and removed comparison-pending fastsim-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 18, 2015

cmsbuild added comparison-available fastsim-approved fully-signed hlt-approved orp-pending reconstruction-approved tests-approved and removed orp-pending pending-signatures reconstruction-approved tests-approved labels May 18, 2015

cmsbuild added comparison-available fastsim-approved fully-signed hlt-approved orp-approved reconstruction-approved tests-approved and removed comparison-available fastsim-approved fully-signed hlt-approved orp-pending reconstruction-approved tests-approved labels May 18, 2015

cmsbuild added a commit that referenced this pull request May 18, 2015

Merge pull request #8356 from BenjaminRS/L3CodeUpdate-March2015

dad49e7

L3 code update march2015

cmsbuild merged commit dad49e7 into cms-sw:CMSSW_7_5_X May 18, 2015

slava77 mentioned this pull request Nov 8, 2016

New seeding framework #16202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L3 code update march2015 #8356

L3 code update march2015 #8356

BenjaminRS commented Mar 17, 2015

cmsbuild commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

lveldere Mar 17, 2015

BenjaminRS Mar 18, 2015

BenjaminRS commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

cmsbuild commented Mar 18, 2015

Martin-Grunewald commented Mar 23, 2015

cmsbuild commented May 18, 2015

davidlange6 commented May 18, 2015

L3 code update march2015 #8356

L3 code update march2015 #8356

Conversation

BenjaminRS commented Mar 17, 2015

cmsbuild commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

lveldere Mar 17, 2015

Choose a reason for hiding this comment

BenjaminRS Mar 18, 2015

Choose a reason for hiding this comment

BenjaminRS commented Mar 17, 2015

Martin-Grunewald commented Mar 17, 2015

cmsbuild commented Mar 18, 2015

Martin-Grunewald commented Mar 23, 2015

cmsbuild commented May 18, 2015

davidlange6 commented May 18, 2015