New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix puppi event content and JEC #8377
Conversation
A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_4_X. Fix puppi event content and JEC It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
@@ -161,7 +162,7 @@ def miniAOD_customizeCommon(process): | |||
) | |||
|
|||
addJetCollection(process, postfix = "", labelName = 'Puppi', jetSource = cms.InputTag('ak4PFJetsPuppi'), | |||
jetCorrections = ('AK4PF', ['L1FastJet', 'L2Relative', 'L3Absolute'], ''), | |||
jetCorrections = ('AK4PFchs', ['L2Relative', 'L3Absolute'], ''), | |||
algo= 'AK', rParam = 0.4, btagDiscriminators = map(lambda x: x.value() ,process.patJets.discriminatorSources) | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L173 and 174 should be removed. SV TagInfos don't seem to be used anywhere so there is no point in adding them and later dropping them in the process of slimming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we do a different PR for this or add it into this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless the idea was to instead add the equivalent of L105-119 for Puppi jets as well.
@jshlee can you see how much disk space does it take, on the usual 9k ttbar events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @gpetruc said, it is needed if the intention is to store some of the SV info as userFloats. If not, then there is no need to add TagInfos. Also note that for slimmedJetsAK8 TopTagInfos are stored for later access to the top tagging information.
Fix puppi event content and JEC
@arizzi @jshlee @violatingcp