Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix puppi event content and JEC #8377

Merged
merged 2 commits into from Mar 20, 2015
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Mar 18, 2015

  • Keep puppi jets (by mistake they were dropped, because of a conflict between the subjet PR and puppi PR)
  • Use AK4PFchs L2+L3 corrections on puppi jets (no L1, since existing L1 corrections for PF or PFchs are not appropriate for puppi)
  • Properly compute jet area for puppi jets (allow application of L1 corrections in the future when they will be available for these jets)

@arizzi @jshlee @violatingcp

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_4_X.

Fix puppi event content and JEC

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@@ -161,7 +162,7 @@ def miniAOD_customizeCommon(process):
)

addJetCollection(process, postfix = "", labelName = 'Puppi', jetSource = cms.InputTag('ak4PFJetsPuppi'),
jetCorrections = ('AK4PF', ['L1FastJet', 'L2Relative', 'L3Absolute'], ''),
jetCorrections = ('AK4PFchs', ['L2Relative', 'L3Absolute'], ''),
algo= 'AK', rParam = 0.4, btagDiscriminators = map(lambda x: x.value() ,process.patJets.discriminatorSources)
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L173 and 174 should be removed. SV TagInfos don't seem to be used anywhere so there is no point in adding them and later dropping them in the process of slimming.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we do a different PR for this or add it into this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless the idea was to instead add the equivalent of L105-119 for Puppi jets as well.
@jshlee can you see how much disk space does it take, on the usual 9k ttbar events?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpetruc, as @ferencek mentioned, SV TagInfos are not saved in slimmedJets and slimmedJetsPuppi (only slimmedJetsAK8), so we don't need to save them in patJets. Similarly, L120-L121 can be removed for patJets too.
I can do a check on the disk space usage of this branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpetruc and @ferencek, I just realised that the SV TagInfos are required by the userData, so we need to keep it while making pat jets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @gpetruc said, it is needed if the intention is to store some of the SV info as userFloats. If not, then there is no need to add TagInfos. Also note that for slimmedJetsAK8 TopTagInfos are stored for later access to the top tagging information.

davidlange6 added a commit that referenced this pull request Mar 20, 2015
Fix puppi event content and JEC
@davidlange6 davidlange6 merged commit 4e8f93e into cms-sw:CMSSW_7_4_X Mar 20, 2015
@ferencek ferencek mentioned this pull request Mar 28, 2015
@gpetruc gpetruc deleted the fixPuppiJEC branch September 30, 2015 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants