Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port back from ROOT6 IB for commonality (DB/ALCA) #8394

Merged
merged 1 commit into from
Mar 20, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 18, 2015

This PR ports back simple changes made in CMSSW_7_4_ROOT6_X in the DB and ALCA L2 categories that are desirable or harmless for CMSSW_7_4_X, in order to increase code commonality. All affected files will be identical in the two releases after this PR is merged. Changes were successfully tested with the short relval matrix.
The changes are:

  1. removal of unnecessary typedef keyword
  2. addition of enum specifications in XML spec files (needed for ROOT6)
  3. addition of typedef specifications in XML files (needed for ROOT6)
  4. removal of unneeded link dependency
  5. removal of unneeded header include
  6. modifications to white space (mostly incidental)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Port back from ROOT6 IB for commonality (DB/ALCA)

It involves the following packages:

CondFormats/Common
CondFormats/DTObjects
CondFormats/EcalObjects
CondFormats/PhysicsToolsObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@apfeiffer1, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 20, 2015
Port back from ROOT6 IB for commonality (DB/ALCA)
@davidlange6 davidlange6 merged commit d1db2c6 into cms-sw:CMSSW_7_4_X Mar 20, 2015
@wmtan wmtan deleted the PortBackFromROOT6DB branch March 20, 2015 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants