Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of MET significance tuning for Phys14 samples #8396

Merged
merged 2 commits into from Mar 19, 2015

Conversation

mmarionncern
Copy link

late update for the MET significance tuning.
Input parameters are computed on Phys14 samples, and the sumpt is now corrected from jet constituents and leptons.

Package involved :
RecoMET/METAlgorithms
RecoMET/METProducers

PR is transparent for reco sequence and tests, as the MET significance is not computed per default.
The PFMETProducer is modified just to take into account the proper change of lepton format in the METSignificance algorithm.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Update of MET significance tuning for Phys14 samples

It involves the following packages:

RecoMET/METAlgorithms
RecoMET/METProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #8396 3263b5b

Corrected the sumpT used for MET significance, which is not computed by default in the standard reco sequences.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-03-18-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants