New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add castor lowPTjet trigger and reweight threshold via gain v2 #8420
add castor lowPTjet trigger and reweight threshold via gain v2 #8420
Conversation
A new Pull Request was created by @cwohrman (Hauke) for CMSSW_7_5_X. add castor lowPTjet trigger and reweight threshold via gain v2 It involves the following packages: SimCalorimetry/CastorTechTrigProducer @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
@cwohrman , I may be do not understand the code of CastorTTRecord but for me there is a problem: |
@civanch, the gain is for all Digis the same. And there is no plan in Sim to change this seperatly for the digis. But the gains over all can change very much from 1 to 5 to 20 depending on the collision for pp, pPb, PbPb. Also a gain weighted summution of the digis I wanted to avoid so that also the thresholds in the config script are in fC related to gain 1. I should also point out that the gain in castor sim is not really used in a commen way. In principle the sim changes also the 'electron response' so you get for example lower fC with higher gain value. And this electron response is coded as one factor for whole castor and thats why you have the same gain for all digis. |
please test |
The tests are being triggered in jenkins. |
@cwohrman , OK, this become clear. How this reweighted_gain appears in the digi collection? |
@civanch , the gain is in the and comming from database. And there it looks in the table for the corresponding digi to get the value. But it is the same for every digi. The point was to avoid adc saturation by higher gain the number of photon electrons produced by cherenkov photons will be reduced. In the end you get then the correct energy again. But the formular which calculates the photoelectrons from cherekov ones is for all digis the same. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
Is this ORP meeting one which I should join or is it more like mandatory? |
@davidlange6 , there is a short report from last Friday: https://indico.cern.ch/event/368377/session/16/contribution/67/material/slides/2.pdf |
I knew about that… but I included the word “plots” for a specific reason..
|
@civanch, @davidlange6, I have also a plot to show the trigger efficiency of the new TTbit62 compared to the hottest sector energy in castor on reco level. The TTbit62 is actually just cutting on the sector energy in castor so this show that the trigger sim does what it should do. Trig eff also for GenJet pT in castor I'm not sure if this is what requested. Cheers, |
+1 |
add castor lowPTjet trigger and reweight threshold via gain v2
Dear all,
this update is to implement the newest castor technical triggers how the will be used during VdM run in 2015.
The 4 trigger bits are
60 gap trigger
61 high pt jet trigger
62 low pt jet trigger (new)
63 muon trigger
Because VdM run will be the only data taking with castor and upcoming MC simulation are using CMSSW_7_4_X.
Especiall the new trigger bit 62 has changed significantly compared to the old version. Also the MC samples are already in proccess of being requested.
So it would be very nice to get it into CMSSW_7_4_X.
The same pull request will be done also for CMSSW 7_5_X.
Any help is welcome.
Thanks,
Hauke