Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosened DMF for miniAOD taus #8421

Merged
merged 1 commit into from Mar 21, 2015

Conversation

andrewj314
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_4_X.

Loosened DMF for miniAOD taus

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@jpavel
Copy link
Contributor

jpavel commented Mar 20, 2015

adding @gpetrucc @arizzi to watch

@arizzi
Copy link
Contributor

arizzi commented Mar 20, 2015

how many more taus per event show up on ttbar sample?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@gpetruc
Copy link
Contributor

gpetruc commented Mar 20, 2015

Comparing pre and post on 9k ttbar, it seeems there's some increase in taus but the new ones are somewhat smaller (maybe e.g. they have less pf candidates inside), so that in all the increase of size is fairly small (0.45 -> 0.63 kb/event). The slimming of taus had saved us ~0.1 kb/event, so I think it's all acceptable.
http://gpetrucc.web.cern.ch/gpetrucc/micro/tau_pre_pr8421.html
http://gpetrucc.web.cern.ch/gpetrucc/micro/tau_post_pr8421.html

davidlange6 added a commit that referenced this pull request Mar 21, 2015
@davidlange6 davidlange6 merged commit 3d6e934 into cms-sw:CMSSW_7_4_X Mar 21, 2015
@roger-wolf roger-wolf deleted the looseTaus_miniAOD branch March 24, 2016 22:17
@@ -64,7 +64,7 @@ def miniAOD_customizeCommon(process):
process.selectedPatJets.cut = cms.string("pt > 10")
process.selectedPatMuons.cut = cms.string("pt > 5 || isPFMuon || (pt > 3 && (isGlobalMuon || isStandAloneMuon || numberOfMatches > 0 || muonID('RPCMuLoose')))")
process.selectedPatElectrons.cut = cms.string("")
process.selectedPatTaus.cut = cms.string("pt > 18. && tauID('decayModeFinding')> 0.5")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the meaning of decay mode finding in this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that the hadronic tau has one of the allowed combinations of charged and neutral components - at the time of that release it had been either 1 track and 0/1/2 strips or 3 tracks. The PR by @andrewj314 allowed also other combinations with 2 tracks and strips in order to account for decreased efficiency that came with increased pileup. But anyway, it is almost 2 years old piece of sw, so it is probably outdated, so I suggest contacting tau conveners for more up-to-date info (I left CMS 1.5y ago ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants