avoid copies of GenEvent and optimizing random number usage in DIGI step #8451
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X. avoid copies of GenEvent and optimizing random number usage in DIGI step It involves the following packages: SimCalorimetry/CaloSimAlgos @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
|
+1 |
avoid copies of GenEvent and optimizing random number usage in DIGI step
Roughly 10% improvement in mixing module time
Main change are:
Avoid copying GenEvent when not needed
Avoid creating a random generator using it once. I'm lazy so used the static methods as done elsewhere in the digitizers. One can easily also make the RandPoissonQ object a member data with the same effect. RandPoissonQ does some setup assuming that the mu its given will be used over and over, so there is a CPU penalty for creating it and using it only once.