Add 1 to the raw HCAL HTR fiber number for HTR histogram firmware unpacking.

[sethcooper]

When unpacking data written with standard HCAL HTR firmware, the HTR fiber number from the raw data has 1 added to it so that the fiber numbers go from 1-8 "offline." This patch does the same for raw data written with the HTR histogramming-mode firmware (for recent histogram firmware versions). Previously this was not the case, leading to confusion and some complications when reading data written by the histogram firmware.

[cmsbuild]

A new Pull Request was created by @sethcooper for CMSSW_7_0_X.

Add 1 to the raw HCAL HTR fiber number for HTR histogram firmware unpacking.

It involves the following packages:

EventFilter/HcalRawToDigi

@thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[nclopezo]

+1
here are the logs for the jenkins tests:
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/576/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/576/

I got an error in the relvals in workflow 4.53 step 2 but I don't think it is related to these changes:

18-Sep-2013 11:22:22 CEST  Initiating request to open file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
130918 11:22:22 8710 Xrd: CheckErrorStatus: Server [eoscms] declared: Unable to get replica filesystem information /eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root; Invalid argument(error code: 3005)
18-Sep-2013 11:22:22 CEST  Fallback request to file root://xrootd.ba.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root
XrdSec: No authentication protocols are available.
130918 11:22:22 8648 Xrd: Open: Authentication failure: cannot obtain credentials for protocol: Secgsi: ErrParseBuffer: unknown CA: cannot verify server certificate: kXGS_init: unable to get protocol object
----- Begin Fatal Exception 18-Sep-2013 11:22:22 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd.ba.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root'
   Additional Info:
      [a] Input file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default could not be opened.
Fallback Input file root://xrootd.ba.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root also could not be opened.
      [b] XrdClient::Open(name='root://xrootd.ba.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root', flags=0x10, permissions=0666) => error 'cannot obtain credentials for protocol: Secgsi: ErrParseBuffer: unknown CA: cannot verify server certificate: kXGS_init: unable to get protocol object.' (errno=3010)
      [c] Current server connection: root://xrootd.ba.infn.it:1094//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root
----- End Fatal Exception -------------------------------------------------
130918 11:22:23 8711 Xrd: XrdClientMessage::ReadRaw: Failed to read header (8 bytes).

[thspeer]

I get the same error when I run the workflow in the IB out of the box, so it is not related to any change.

[ktf]

I agree, this is a deleted file which is being looked up in Bari... I suspect the ongoing router updates might have a role in this...

[thspeer]

+1
Tested 6e2f7c6
No difference in reco, based on Jenkins

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?