MuonIdProducer code cleaning

[jhgoh]

This is cleanup of MuonIdProducer in C++ code level (and simplification with C++0x syntax).
This is purely technical code change, basicaly no change in logic.

Thus output must be bitwise identical. - no difference with very small statistics for muons using the runEdmFileComparison.py tool.
Small improvement of CPU timing is observed TTbarLepton Pileup RelVal sample (1.314 -> 1.251 sec/evt).

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_5_X.

MuonIdProducer code cleaning

It involves the following packages:

RecoMuon/MuonIdentification

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: d4a91b3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8523/3797/summary.html

[cvuosalo]

+1

For #8523 82d019e

Clean-up of MuonIdProducer code. There should be no change in program outputs.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-04-02-1100 show no significant differences, as expected. Short matrix tests also show no significant differences, and execution time of muon-related modules shrinks slightly.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1